Correct calculated doca in KF tracking#1108
Open
tongtongcao wants to merge 2 commits intodevelopmentfrom
Open
Conversation
tongtongcao
requested review from
hauenst,
raffaelladevita and
zieglerv
as code owners
Collaborator
|
Tested successfully on straight track data, see |
Collaborator
|
Tests on production data show this eliminates multimodal shapes in residuals vs. doca in R1 and R3, but makes R2 worse. Checking further, it looks like this is due to https://github.com/JeffersonLab/coatjava/blob/development/reconstruction/dc/src/main/java/org/jlab/rec/dc/hit/FittedHit.java#L377 that makes alpha different from the track local angle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In KF tracking, calculated doca is defined as projection point of fit trajectory and wire line, but doca is supposed to the closest approach between trajectory and wire line. Therefore, calculated doca is corrected by alpha at TB level.
As test, the update fixes issue for bias of fit residual.
No effect on HB tracking.
Change on TB track is slight since effects on L&R hits offset and hit error is scaled by 2 during tracking.